Matthias Clasen [Sun, 3 Jan 2016 22:23:59 +0000 (17:23 -0500)]
Update expected output
The previous commit changed the format of the output
generated by the CSS style tests.
Matthias Clasen [Sun, 3 Jan 2016 22:05:16 +0000 (17:05 -0500)]
Improve formatting of CSS style prints
Add a newline after CSS properties, so things don't run into
each other.
Matthias Clasen [Sun, 3 Jan 2016 21:14:43 +0000 (16:14 -0500)]
Skip GdkX11DeviceManagerCore in default value tests
We already skip the XI2 implementation, and the core
one needs the same treatment.
Matthias Clasen [Sun, 3 Jan 2016 20:41:09 +0000 (15:41 -0500)]
Update expected output for CSS style tests
The format for CSS values changed slightly in one of the
previous commits.
Matthias Clasen [Sun, 3 Jan 2016 20:37:40 +0000 (15:37 -0500)]
Use a custom theme for CSS style tests
Use a custom, empty theme and stop importing reset-to-defaults.css.
This avoids overwriting initial values, so our initial value
filtering works better.
Matthias Clasen [Sun, 3 Jan 2016 20:34:08 +0000 (15:34 -0500)]
Redo CSS style printing
Drop the custom style printing implementation in gtkcssnode.c and
instead reuse the existing gtk_css_style_print function, extending
it a bit to suit our needs.
Instead of computing values, just recognize initial values by
having no CSS section. Also do away with the show-initial flag, and
just always filter out initial values. The flag can come back when
it is needed.
Matthias Clasen [Sun, 3 Jan 2016 19:04:52 +0000 (14:04 -0500)]
Update expected output for node and style tests
The previous commit changed the format of the output.
Matthias Clasen [Sun, 3 Jan 2016 19:02:00 +0000 (14:02 -0500)]
Move node printing to GtkCssNodeDeclaration
The node declaration has all the information we are printing
here (except for visibility). At the same time, redo the format
to print the information in selector format, and indicate
(in)visibility by enclosing the selector in square brackets.
Cosimo Cecchi [Sun, 3 Jan 2016 19:33:19 +0000 (11:33 -0800)]
tests: fix Makefile.am syntax
It requires a tab character, or the build will fail.
Cosimo Cecchi [Sun, 3 Jan 2016 19:25:45 +0000 (11:25 -0800)]
cssnode: fix a compiler warning
Matthias Clasen [Sun, 3 Jan 2016 17:05:57 +0000 (12:05 -0500)]
Fix the build
Matthias Clasen [Sun, 3 Jan 2016 16:59:15 +0000 (11:59 -0500)]
Forgotten file
I forgot to add this file to source control when the new tests
were initially added.
Felix Riemann [Sun, 3 Jan 2016 14:32:38 +0000 (15:32 +0100)]
shortcuts: Separate gestures in search results
Gestures where shown separately from other shortcuts in the search
results before. This restores that behaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=760097
Felix Riemann [Sun, 3 Jan 2016 14:22:06 +0000 (15:22 +0100)]
shortcuts: Show icons and subtitles for gestures in search results
https://bugzilla.gnome.org/show_bug.cgi?id=760097
Matthias Clasen [Sun, 3 Jan 2016 15:56:11 +0000 (10:56 -0500)]
Update expected results of a11y tests
All of these now have a harmless extra "panel".
Matthias Clasen [Sun, 3 Jan 2016 15:42:13 +0000 (10:42 -0500)]
lockbutton: Fix up the template
I forgot to clean this up when switching to a stack.
Matthias Clasen [Sun, 3 Jan 2016 15:34:40 +0000 (10:34 -0500)]
Skip GdkX11DeviceManagerCore in notify tests
We already skip the XI2 implementation, and the core
one needs to the same treatment.
Matthias Clasen [Sun, 3 Jan 2016 15:33:54 +0000 (10:33 -0500)]
assistant: Drop unnecessary frame
We can just style the sidebar box itself, no need for an
extra frame widget.
Matthias Clasen [Sun, 3 Jan 2016 14:55:30 +0000 (09:55 -0500)]
lockbutton: Use a stack
The previous way of manually juggling the visibility of the
labels doesn't work anymore, now that gadgets of invisible
widgets don't allocate space anymore.
Matthias Clasen [Tue, 29 Dec 2015 04:26:50 +0000 (23:26 -0500)]
Add a css style test for currentColor
Matthias Clasen [Tue, 29 Dec 2015 04:20:57 +0000 (23:20 -0500)]
Add a css style test for inherit and initial
Matthias Clasen [Mon, 28 Dec 2015 18:59:10 +0000 (13:59 -0500)]
Add a css style test for :first/last/only-child
Matthias Clasen [Mon, 28 Dec 2015 17:39:54 +0000 (12:39 -0500)]
Add a css style test for font inheritance
Matthias Clasen [Tue, 29 Dec 2015 12:44:53 +0000 (07:44 -0500)]
Add a test framework for CSS styles
This uses the same function for dumping CSS nodes and styles
as the CSS node test. It can be used to test aspects of inheritance
and matching, as well as initial values.
No actual tests yet.
Matthias Clasen [Mon, 28 Dec 2015 16:00:32 +0000 (11:00 -0500)]
Add CSS node tests for levelbars
Matthias Clasen [Mon, 28 Dec 2015 15:52:20 +0000 (10:52 -0500)]
Add CSS node test for progressbars
Matthias Clasen [Mon, 28 Dec 2015 15:35:58 +0000 (10:35 -0500)]
Add a CSS node test for buttons
Matthias Clasen [Mon, 28 Dec 2015 07:00:58 +0000 (02:00 -0500)]
Add a CSS node test for entries
Matthias Clasen [Mon, 28 Dec 2015 07:03:29 +0000 (02:03 -0500)]
Add a CSS node test for notebooks
Matthias Clasen [Mon, 28 Dec 2015 07:02:57 +0000 (02:02 -0500)]
Add a test framework for CSS nodes
No actual tests yet.
Matthias Clasen [Mon, 28 Dec 2015 06:09:54 +0000 (01:09 -0500)]
Add a function to dump CSS nodes and styles
Add a gtk_style_context_to_string function that can serialize
a CSS node or tree of nodes, optionally including CSS properties
as well.
This will be useful in writing tests.
Cosimo Cecchi [Sun, 3 Jan 2016 09:02:12 +0000 (01:02 -0800)]
infobar: remove unneeded gadget
It turns out we don't really need to use a separate gadget for the
infobar, if all we do is chaining up to the parent GtkBox which already
uses a gadget.
Just remove all the boilerplate.
Cosimo Cecchi [Sun, 3 Jan 2016 08:54:16 +0000 (00:54 -0800)]
window: remove unused variables
Cosimo Cecchi [Sun, 3 Jan 2016 01:54:06 +0000 (17:54 -0800)]
levelbar: consolidate code into single function
Cosimo Cecchi [Sun, 3 Jan 2016 02:03:50 +0000 (18:03 -0800)]
levelbar: port to use gadgets
We now use one gadget for the trough, and one for each block.
Cosimo Cecchi [Sun, 3 Jan 2016 02:03:15 +0000 (18:03 -0800)]
levelbar: split out a function
Cosimo Cecchi [Sat, 2 Jan 2016 23:28:12 +0000 (15:28 -0800)]
infobar: port to use a gadget
Cosimo Cecchi [Sat, 2 Jan 2016 23:09:21 +0000 (15:09 -0800)]
infobar: trivial code cleanups
Cosimo Cecchi [Sat, 2 Jan 2016 22:59:56 +0000 (14:59 -0800)]
menubar: prefer early return
Cosimo Cecchi [Fri, 1 Jan 2016 23:23:27 +0000 (15:23 -0800)]
menubar: port to use a gadget
Cosimo Cecchi [Fri, 1 Jan 2016 23:19:21 +0000 (15:19 -0800)]
menubar: use gtk_container_class_handle_border_width()
Cosimo Cecchi [Wed, 30 Dec 2015 19:07:26 +0000 (11:07 -0800)]
HighContrast: remove unused selector
There's no header-bar-separator style class.
Cosimo Cecchi [Wed, 30 Dec 2015 19:06:46 +0000 (11:06 -0800)]
Adwaita: remove unused selector
There's no header-bar-separator style class.
Cosimo Cecchi [Wed, 30 Dec 2015 18:59:56 +0000 (10:59 -0800)]
HighContrast: update for separators deprecations
HighContrast still has a long way to go, but let's get at least
separators working again.
Cosimo Cecchi [Wed, 30 Dec 2015 18:54:14 +0000 (10:54 -0800)]
HighContrast: reparse theme
For some reason, this got accidentally changed in a previous commit.
This is just the output of running parse-sass.sh again.
Cosimo Cecchi [Wed, 30 Dec 2015 18:53:27 +0000 (10:53 -0800)]
win32: remove ineffective selector
That style property is deprecated, but the combobox does not have a
separator anymore.
Cosimo Cecchi [Wed, 30 Dec 2015 18:51:14 +0000 (10:51 -0800)]
widget: deprecate separator style properties
They're not used in GTK anymore. Also remove them from the default
theme.
Cosimo Cecchi [Wed, 30 Dec 2015 18:36:28 +0000 (10:36 -0800)]
treeview: don't use wide-separators/separator-height
Those style properties are on their way out; instead, use min-height
with the separator style class to obtain the height.
Cosimo Cecchi [Wed, 30 Dec 2015 02:02:21 +0000 (18:02 -0800)]
treeview: prefer positive polarity in if block
Cosimo Cecchi [Wed, 30 Dec 2015 01:44:01 +0000 (17:44 -0800)]
separator: don't read wide-separators style property
The notion of a separator being wide or not does not make sense when a
theme can set any CSS property on it, and
separator-width/separator-height are on their way out for
min-width/min-height.
Cosimo Cecchi [Wed, 30 Dec 2015 01:40:30 +0000 (17:40 -0800)]
menuitem: don't read wide-separators or separator-height
Separators inside menus are working completely through CSS since
GtkMenuItem has been ported to use a gadget.
Remove this unused code from here.
Cosimo Cecchi [Tue, 29 Dec 2015 20:34:16 +0000 (12:34 -0800)]
separatortoolitem: don't use custom sizing/rendering
Instead, just rely on the CSS gadget; we can stop using wide-separators,
separator-height and separator-width, and at the same time deprecate the
space-size style property of GtkToolbar.
Cosimo Cecchi [Tue, 29 Dec 2015 20:14:02 +0000 (12:14 -0800)]
separatortoolitem: trivial code cleanups
Cosimo Cecchi [Wed, 30 Dec 2015 01:33:08 +0000 (17:33 -0800)]
toolbar: deprecate GtkToolbarSpaceStyle and space-style style property
This is completely unused already.
Cosimo Cecchi [Wed, 30 Dec 2015 00:47:04 +0000 (16:47 -0800)]
toolbar: port to use a gadget
Cosimo Cecchi [Mon, 28 Dec 2015 20:51:25 +0000 (12:51 -0800)]
toolbar: use gtk_container_handle_border_width()
Cosimo Cecchi [Mon, 28 Dec 2015 20:37:56 +0000 (12:37 -0800)]
toolbar: trivial code cleanup
Felix Riemann [Sat, 2 Jan 2016 20:28:51 +0000 (21:28 +0100)]
GtkBindings: Fix CSS key in example docs
gtk-key-bindings was renamed to -gtk-key-bindings in
d267b8e0.
https://bugzilla.gnome.org/show_bug.cgi?id=760082
Matthias Clasen [Sun, 3 Jan 2016 06:25:07 +0000 (01:25 -0500)]
Fix stylecontext tests to work
Some of the tests don't work anymore because they test
features of saved style contexts that have changed, and some
now trigger deprecation warnings.
Matthias Clasen [Sun, 3 Jan 2016 06:23:35 +0000 (01:23 -0500)]
Skip GdkX11DeviceManagerCore in finalize tets
We already skip the XI2 implementation, and the core
one needs to the same treatment.
Christoph Reiter [Fri, 1 Jan 2016 11:57:46 +0000 (12:57 +0100)]
gtkwindow: fix first allocation size
67ab00e01ec06d7b removed the fake configure code in gtk_window_show() and
replaced it with a simple gtk_widget_realize(). The initial allocation
code in realize() only allocates the natural size or the last requested
size which now no longer is set, resulting in a too small first allocation.
This builds a configure request to compute the allocation size instead
which includes default size, CSD etc..
This problem could be seen in case of a GtkPaned in a GtkWindow with a
default size set and the pane position set as well. The first allocation
would be the natural size of the GtkPaned which would clamp the pane
position if too larg. Only the second allocation would fill the parent
window using the now wrong pane position.
https://bugzilla.gnome.org/show_bug.cgi?id=759705
Matthias Clasen [Sun, 3 Jan 2016 02:08:50 +0000 (21:08 -0500)]
Revert "Revert "window: Remove suspicious branch""
This reverts commit
2438a06d54636e5074c29bd696e3e81e90288b8d.
See https://bugzilla.gnome.org/show_bug.cgi?id=759705
Cosimo Cecchi [Sun, 3 Jan 2016 02:14:47 +0000 (18:14 -0800)]
levelbar: fix a crash
We should not try to access a block with an index that exceeds the
number of blocks in the widget.
Matthias Clasen [Sun, 3 Jan 2016 01:53:54 +0000 (20:53 -0500)]
separator toolitem: Respect ::draw property
This was lost when I converted the widget to use a gadget.
https://bugzilla.gnome.org/show_bug.cgi?id=760018
Cosimo Cecchi [Fri, 1 Jan 2016 22:50:43 +0000 (14:50 -0800)]
spinbutton: fix a typo
Cosimo Cecchi [Sat, 2 Jan 2016 23:28:35 +0000 (15:28 -0800)]
menuitem: move chaining up to draw inside gadget
This is more consistent with what other widgets do.
Marek Černocký [Sat, 2 Jan 2016 20:13:40 +0000 (21:13 +0100)]
Updated Czech translation
Timm Bäder [Sat, 2 Jan 2016 14:40:50 +0000 (15:40 +0100)]
testframe: Pass correct state to GtkStyleContext API
Timm Bäder [Wed, 30 Dec 2015 14:45:07 +0000 (15:45 +0100)]
GtkImage: Simplify _set_from_icon_name
We don't need to strdup icon_name since that will happen in
_gtk_icon_helper_set_icon_name anyway.
Andika Triwidada [Sat, 2 Jan 2016 12:27:16 +0000 (12:27 +0000)]
Updated Indonesian translation
(cherry picked from commit
45b3c553a93ed6a9e3eea26e7c8337dcd9fa77b6)
Andika Triwidada [Sat, 2 Jan 2016 12:22:34 +0000 (12:22 +0000)]
Updated Indonesian translation
(cherry picked from commit
1aa5f9278423f370d7490d83e8582dae087e2f6a)
Rafael Fontenelle [Sat, 2 Jan 2016 06:48:23 +0000 (06:48 +0000)]
Updated Brazilian Portuguese translation
(cherry picked from commit
e96c689aa1e60e561f4db67725d53fccc44234ec)
Christoph Reiter [Thu, 17 Dec 2015 17:02:13 +0000 (18:02 +0100)]
gtkdnd-quartz: fix gtk_drag_begin_internal
gtk_drag_begin_internal was changed to take a GtkImageDefinition
instead of a GtkIconHelper. This adjusts the quartz variant
accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=759607
Alberts Muktupāvels [Mon, 28 Dec 2015 18:46:23 +0000 (20:46 +0200)]
gtkheaderbar: update window buttons also on realize
After
bb34db6 _gtk_header_bar_update_window_buttons function is
called before application menu is set. This caused regression -
app menu button is initially hidden.
https://bugzilla.gnome.org/show_bug.cgi?id=756618
Yosef Or Boczko [Thu, 31 Dec 2015 17:39:41 +0000 (19:39 +0200)]
Updated Hebrew translation
Yosef Or Boczko [Thu, 31 Dec 2015 17:38:23 +0000 (19:38 +0200)]
Updated Hebrew translation
Yosef Or Boczko [Thu, 31 Dec 2015 16:49:30 +0000 (18:49 +0200)]
Updated Hebrew translation
Yosef Or Boczko [Thu, 31 Dec 2015 16:47:57 +0000 (18:47 +0200)]
Updated Hebrew translation
Руслан Ижбулатов [Wed, 30 Dec 2015 18:05:36 +0000 (18:05 +0000)]
Fix include path for gtkiconfactoryprivate.h
Руслан Ижбулатов [Wed, 30 Dec 2015 18:05:05 +0000 (18:05 +0000)]
Fix to compile for C libraries with no flockfile
Also use MS variant of flockfile, if available
(requires MSVCRT compatible with MSVCR90 or newer).
Cosimo Cecchi [Wed, 30 Dec 2015 18:44:12 +0000 (10:44 -0800)]
scrolledwindow: add missing deprecation flag
Cosimo Cecchi [Wed, 30 Dec 2015 02:31:10 +0000 (18:31 -0800)]
menuitem: fix a crash when reserve_indicator is TRUE
In that case, code expects an arrow gadget to be present but we're not
creating it in every occurrence.
Fix it by ensuring there will be an arrow gadget when reserve_indicator
is TRUE.
Cosimo Cecchi [Wed, 30 Dec 2015 00:33:34 +0000 (16:33 -0800)]
toolitem: fix a copy/paste typo
Cosimo Cecchi [Wed, 23 Dec 2015 17:54:42 +0000 (09:54 -0800)]
scrolledwindow: port to use a gadget
Cosimo Cecchi [Wed, 23 Dec 2015 04:45:33 +0000 (20:45 -0800)]
scrolledwindow: deprecate scrollbars-within-bevel style property
These days all the themes set it to TRUE, and it's not clear what
happens with overlay scrollbars...
Cosimo Cecchi [Mon, 28 Dec 2015 20:21:27 +0000 (12:21 -0800)]
viewport: don't render a background over the bin window
GtkViewport currently tries to draw a background over the bin window.
The feature is a bit broken at the moment, as it does not take into
account padding that might have been set on the GtkViewport, but in
general it does not seem very useful, and goes somewhat against the CSS
box model where every widget/gadget is responsible to draw its own
background. For a fix, we could either have the viewport gain a "bin"
gadget, or we could stop drawing the background.
As it isn't clear that there are any users of this feature, stop drawing
the background; a client can achieve the same effect by drawing the
background on the widget inside the viewport itself.
Cosimo Cecchi [Wed, 23 Dec 2015 01:55:18 +0000 (17:55 -0800)]
viewport: port to use a gadget
This will get us margin support, among other things, and simplifies the
code.
Cosimo Cecchi [Wed, 23 Dec 2015 00:26:28 +0000 (16:26 -0800)]
viewport: trivial code cleanup
Cosimo Cecchi [Tue, 22 Dec 2015 23:10:23 +0000 (15:10 -0800)]
viewport: use gtk_container_class_handle_border_width()
No need to do this manually.
Benjamin Otte [Wed, 23 Dec 2015 00:50:20 +0000 (01:50 +0100)]
gadget: Handle visibility
As GtkCssNode has the visibility concept, it makes sense to mirror it in
gadgets.
Do what visibility does in widgets: Hidden gadgets can't be drawn or
allocated and request a 0x0 size.
Note that just like widgets, gadget visibility must not be changed in
size request, allocate or draw handlers.
GtkWidget::child-visible has no equivalent yet, code will have to
emulate that manually.
Matthias Clasen [Sat, 16 May 2015 22:54:35 +0000 (18:54 -0400)]
Drop deprecated pango-utils api
Copy the few parsing functions we need.
Ben Iofel [Mon, 28 Dec 2015 03:13:21 +0000 (19:13 -0800)]
Raleigh: Don't use deprecated pseudo classes
Matthias Clasen [Tue, 29 Dec 2015 04:15:53 +0000 (23:15 -0500)]
Set ID on css node right away
Previously, the ID was only set on the CSS node as a side-effect
of calling gtk_widget_get_style_context. This was showing up
in CSS style tests as nodes lacking their IDs.
Matthias Clasen [Tue, 29 Dec 2015 03:36:29 +0000 (22:36 -0500)]
Fix a comment
Matthias Clasen [Mon, 28 Dec 2015 19:41:33 +0000 (14:41 -0500)]
Add a transfer annotation
This was confusing me momentarily, so add an explicit annotation.
Mario Blättermann [Mon, 28 Dec 2015 21:16:11 +0000 (21:16 +0000)]
Updated German translation
Matthias Clasen [Mon, 28 Dec 2015 15:27:08 +0000 (10:27 -0500)]
statusicon: Avoid criticals
The code handles the possibility of pixbuf being NULL, but
after
b411c318321fd4de556926119cbc6e3ba14f073a we must be
prepared for surface already being NULL. Pointed out by
Albert Muktupāvels,
https://bugzilla.gnome.org/show_bug.cgi?id=759917
Matthias Clasen [Mon, 28 Dec 2015 15:24:02 +0000 (10:24 -0500)]
checkbutton: Update state initially
Without this, the check node starts out without the :dir(ltr)
state, at least.
Matthias Clasen [Sun, 27 Dec 2015 23:37:19 +0000 (18:37 -0500)]
css: Deprecate :sorted pseudo class
This was used with regions in GtkTreeView, and is not used
anymore, so deprecate it.
Matthias Clasen [Sun, 27 Dec 2015 22:31:27 +0000 (17:31 -0500)]
Fix outline-radius css parser test
The outline-radius properties all got a -gtk prefix.